Repository navigation
Discover official Windows Obsidian installs - #55
Merged
Merged
Conversation
(packages/obsidian-test-session/src/environment.ts) - Search the official per-user and all-user installation roots before PATH on Windows. - Recognise Obsidian.com and the legacy obsidian-cli.exe terminal entry point. (packages/obsidian-test-session/src/environment.test.ts) - Cover per-user discovery without PATH and exact fallback ordering for both CLI names. (packages/obsidian-test-session/src/vault.test.ts) - Check temporary Vault containment with platform-aware relative paths. (packages/obsidian-test-session/README.md, packages/obsidian-test-session/updates.md) - Document the Windows lookup contract and platform coverage.
Owner
|
Thank you so much for this PR and for testing it on Windows! This is a very helpful improvement. I would also like to add a small follow-up with regression tests to cover native all-user installs when using 32-bit Node on 64-bit Windows. I think covering this case now will make future maintenance easier. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PATH.Obsidian.comterminal redirector and the legacyobsidian-cli.exename.Compatibility
OBSIDIAN_BINARYandOBSIDIAN_CLIoverrides retain priority.PATHand removes duplicate standard roots.Verification
npx -y npm@11.18.0 run test --workspace @vrtmrz/obsidian-test-session -- --reporter=dot: 81 passed, 7 skipped.npx -y npm@11.18.0 run verify:workspace: passed all type, lint, unit, build, pack, and installed-consumer checks, including 983octagonal-wheelstests.test:e2e:obsidian:session-lifecyclepassed.test:e2e:obsidian:smokepassed.PATH; each consumer rejected the missing CLI and reported every inspected candidate.profile-restart.tsreached its post-restart assertion after successful discovery and two isolated launches; its local-storage persistence assertion observednull.test:e2e:obsidian:validatedselected the reviewed 1.13.6 target, then its Windows nested-command launcher returnedspawn EINVALbefore starting an Obsidian session.