Skip to content

Attempt to add multi-platform builds (copilot-agogo) - #94

Open
paullaycock wants to merge 7 commits into
vre-hub:mainfrom
paullaycock:fix-multiplatform-workflow
Open

paullaycock wants to merge 7 commits into
vre-hub:mainfrom
paullaycock:fix-multiplatform-workflow

Conversation

@paullaycock

Copy link
Copy Markdown
Contributor

Developing on a mac, it was painful not to have the arm images and have a working but not working status through emulation.. it would be great to at least have the py311 base image have a cross-platform build, this is intended to be a generic fix

@paullaycock
paullaycock requested a review from a team as a code owner July 30, 2026 17:07

@Soap2G Soap2G left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @paullaycock, cross-platform builds would be indeed useful.

A few thoughts:

  1. This changes the shared build-and-push-image step used by the whole matrix, so it'll apply to whatever directory happens to be touched on a future push

There are a few environments that would break under linux/arm64:

  • vre-singleuser-root — base is jupyter/scipy-notebook:python-3.9.5, which has no arm64 manifest at all (confirmed via the Docker Hub registry API). Build fails right at FROM.

  • atlas-ntuples — same problem, rootproject/root:6.24.06-ubuntu20.04 is amd64-only.

  • vre-singleuser-dask-root — FROMs vre-singleuser-root, inherits both issues.

  1. We could scope platforms: per matrix entry; I've added a suggestion that only adds arm for specific images.
    (I may have messed up the indentation, but the idea is there)

  2. Last thing: env-build.yaml triggers only on push to main, i.e. there's no way to test this before merging the PR. I've suggested to add a test build on PRs.

Comment thread .github/workflows/env-build.yaml Outdated
Comment thread .github/workflows/env-build.yaml Outdated
Comment thread .github/workflows/env-build.yaml
Comment thread .github/workflows/env-build.yaml Outdated
Comment thread .github/workflows/env-build.yaml Outdated
paullaycock and others added 6 commits September 16, 2026 19:23
Co-authored-by: Giovanni Guerrieri <49747129+Soap2G@users.noreply.github.com>
Co-authored-by: Giovanni Guerrieri <49747129+Soap2G@users.noreply.github.com>
Co-authored-by: Giovanni Guerrieri <49747129+Soap2G@users.noreply.github.com>
Co-authored-by: Giovanni Guerrieri <49747129+Soap2G@users.noreply.github.com>
Co-authored-by: Giovanni Guerrieri <49747129+Soap2G@users.noreply.github.com>
pull_request: was a stray top-level key instead of nested under on:,
so GitHub Actions ignored it (unrecognized top-level keys are
silently dropped) and the workflow still only triggered on push,
never on PRs - defeating the point of adding a PR-triggered test
build. Nest it under on: alongside push.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@paullaycock

Copy link
Copy Markdown
Contributor Author

Going with opt-in as discussed in person.

Also fixed a bug: the pull_request: trigger was indented as a stray top-level key instead of nested under on:, so PR-triggered test builds weren't actually running (GitHub Actions silently ignores unrecognized top-level keys). Nested it under on: alongside push: - PR builds should now actually trigger.

@paullaycock
paullaycock requested a review from Soap2G September 16, 2026 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants