Attempt to add multi-platform builds (copilot-agogo) - #94
paullaycock wants to merge 7 commits into
Conversation
There was a problem hiding this comment.
Thanks @paullaycock, cross-platform builds would be indeed useful.
A few thoughts:
- This changes the shared build-and-push-image step used by the whole matrix, so it'll apply to whatever directory happens to be touched on a future push
There are a few environments that would break under linux/arm64:
-
vre-singleuser-root — base is jupyter/scipy-notebook:python-3.9.5, which has no arm64 manifest at all (confirmed via the Docker Hub registry API). Build fails right at FROM.
-
atlas-ntuples — same problem, rootproject/root:6.24.06-ubuntu20.04 is amd64-only.
-
vre-singleuser-dask-root — FROMs vre-singleuser-root, inherits both issues.
-
We could scope
platforms:per matrix entry; I've added a suggestion that only adds arm for specific images.
(I may have messed up the indentation, but the idea is there) -
Last thing:
env-build.yamltriggers only on push to main, i.e. there's no way to test this before merging the PR. I've suggested to add a test build on PRs.
Co-authored-by: Giovanni Guerrieri <49747129+Soap2G@users.noreply.github.com>
Co-authored-by: Giovanni Guerrieri <49747129+Soap2G@users.noreply.github.com>
Co-authored-by: Giovanni Guerrieri <49747129+Soap2G@users.noreply.github.com>
Co-authored-by: Giovanni Guerrieri <49747129+Soap2G@users.noreply.github.com>
Co-authored-by: Giovanni Guerrieri <49747129+Soap2G@users.noreply.github.com>
pull_request: was a stray top-level key instead of nested under on:, so GitHub Actions ignored it (unrecognized top-level keys are silently dropped) and the workflow still only triggered on push, never on PRs - defeating the point of adding a PR-triggered test build. Nest it under on: alongside push. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
Going with opt-in as discussed in person. Also fixed a bug: the |
Developing on a mac, it was painful not to have the arm images and have a working but not working status through emulation.. it would be great to at least have the py311 base image have a cross-platform build, this is intended to be a generic fix