Repository navigation
chore: update dependencies (2026-09-30) and mark fire and forget executions - #113
Merged
Merged
Conversation
SonarCloud rule S9383 (floating promises) flags the eight `execute()` and `resubmit()` calls made by the autoExecute, executeWhen, window focus and document visibility handlers, and fails the quality gate of the release PR. They are fire and forget by design, and `execute()` never rejects: a failure lands in the query state. Mark them with `void`, as the rule suggests for promises that cannot practically reject. No behavior change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 8 minutes. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Minor/patch bumps: @types/node, eslint, unplugin-dts, vite and vitest; packageManager pnpm@12.4.2 -> pnpm@12.8.1. Held back on purpose: - typescript stays at 6.0.3: TS 7 drops the JavaScript Compiler API until 7.1, which breaks declaration emit in unplugin-dts; - vitest resolves to 5.0.2, not 5.0.3: 5.0.3 was published a few hours ago and pnpm's one-day minimum release age applies; the next update picks it up. No newly locked package version is younger than one day. The emitted .d.ts files are byte for byte identical to the ones before the update. Type-check, lint, the 81 unit tests and the build all pass. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
alessandrobellesia
changed the title
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two changes on the way to the 2.1.0 release (#112).
1. Mark the watchers' executions as intentionally not awaited
The quality gate of #112 fails on reliability: SonarCloud rule S9383 ("Promises should not be left unhandled") flags 8 pre-existing calls in
src/utilities.ts. The rule was not reported on #110.The
autoExecute,executeWhen, window focus and document visibility handlers callexecute()/resubmit()without awaiting them. That is by design: they are fire and forget, and since #110execute()never rejects, because a failure lands in the query state. The 8 calls are marked withvoid, which is the fix the rule suggests for promises that cannot practically reject. It does not swallow anything: an unexpected rejection still reaches the runtime as an unhandled rejection. No behavior change.2. Dependencies update (
ncu)@types/node^26.6.3,eslint^10.11.0,unplugin-dts1.1.1,vite^8.3.1,vitest^5.0.2.packageManagerpnpm@12.4.2->pnpm@12.8.1.peerDependenciesuntouched.Held back on purpose:
typescriptstays at6.0.3: TS 7 drops the JavaScript Compiler API until 7.1, which breaks declaration emit inunplugin-dts(7.0.2 is the latest).vitestresolves to5.0.2, not5.0.3: 5.0.3 was published a few hours ago and pnpm's one-day minimum release age applies (ncu --cooldown 1). The next update picks it up.Supply chain check: the lockfile adds 9 package versions (plus the
@pnpm/exe.*binaries), none published in the last 24 hours; the newest ispnpm@12.8.1(2026-09-28).CHANGELOG: the
[2.1.0]entry gets a "dependencies update" line.Checks
pnpm test: 81/81 passedCI=true pnpm lint: cleanpnpm type-check: cleanpnpm build: clean, and the emitted.d.tsfiles are byte for byte identical to the ones before the update🤖 Generated with Claude Code