You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
π¨ Your current dependencies have known security vulnerabilities π¨
This dependency update fixes known security vulnerabilities. Please see the details below and assess their impact carefully. We recommend to merge and deploy this as soon as possible!
Here is everything you need to know about this update. Please take a good look at what changed and the test results before merging this pull request.
Two independent quadratic paths in the linkify: true handling. Both are in markdown-it's own code rather than in linkify-it, which stays linear on both payloads.
src/rules_core/linkify.ts calls arrayReplaceAt once per linkified text token, and that rebuilds the whole children array each time. A paragraph of N soft-broken lines is one inline token with about 2N children, so you get N rebuilds over a 2N array. Schema-less emails are what reach it. A http:// link gets consumed by the inline rule first and never arrives as a text token, so those stay linear.
src/rules_inline/linkify.ts runs state.pending.match(SCHEME_RE) at every :// in the source. state.pending only gets truncated once a link is actually produced, so an unregistered scheme leaves it growing and every :// rescans the lot.
Proof of concept
Clean install of 15.0.0 from npm, new MarkdownIt({ linkify: true }).render(payload), Node 24.
N
5,000
10,000
20,000
40,000
'a@b.co\n'.repeat(N), 34KB to 273KB
1.1s
4.7s
19.6s
89s
'a://'.repeat(N), 20KB to 156KB
0.25s
0.76s
3.1s
15.0s
Doubling the input roughly quadruples the time in both. With linkify: false the same inputs run in 25 to 131ms and stay flat.
Controls for the first one, all at N=20000: putting every email in a single text token ('a@b.co ') takes 0.59s, one email per paragraph ('a@b.co\n\n') takes 0.64s, and soft-broken lines with nothing linkifiable take 42ms. So it needs many children AND many of them linkifying. For the second, replaying just the SCHEME_RE calls against the same growing prefixes with no markdown-it involved accounts for 11.7s of the 15s.
Ordinary prose does it too. 'ping a@b.co ok\n'.repeat(20000) is 293KB and takes 31s.
Caveat
linkify is off by default, so this only reaches apps that turn it on.
Impact
Availability only. A few hundred KB of fairly ordinary markdown pins one core for tens of seconds, and because it's quadratic it degrades quickly with size. Nothing is read, written or executed.
Release Notes
14.3.0 (from changelog)
Changed
Reworked build pipeline & tools.
Added source maps.
Bumped linkify-it to 5.0.2.
Fixed
Preserve backslash-space hard line breaks, matching CommonMark 6.7, #1185.
Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.
All Depfu comment commands
@βdepfu rebase
Rebases against your default branch and redoes this update
@βdepfu recreate
Recreates this PR, overwriting any edits that you've made to it
@βdepfu merge
Merges this PR once your tests are passing and conflicts are resolved
@βdepfu cancel merge
Cancels automatic merging of this PR
@βdepfu close
Closes this PR and deletes the branch
@βdepfu reopen
Restores the branch and reopens this PR (if it's closed)
@βdepfu pause
Ignores all future updates for this dependency and closes this PR
@βdepfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@βdepfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
π¨ Your current dependencies have known security vulnerabilities π¨
This dependency update fixes known security vulnerabilities. Please see the details below and assess their impact carefully. We recommend to merge and deploy this as soon as possible!
Here is everything you need to know about this update. Please take a good look at what changed and the test results before merging this pull request.
What changed?
β³οΈ markdown-it (14.2.0 β 14.3.2) Β· Repo Β· Changelog
Security Advisories π¨
π¨ markdown-it linkify: true has two quadratic paths, so a few hundred KB of markdown blocks the event loop for tens of seconds
Release Notes
14.3.0 (from changelog)
Does any of this look wrong? Please let us know.
Commits
See the full diff on Github. The new version differs by 41 commits:
14.3.2 releasedBackported 15.0.2 fixes14.3.1 releasedBackported 15.0.1 fixesIgnore generated API docs in lintPrepare package.json for v14 backportsfix: recognize lowercase declarations as HTML blocks (CommonMark 4.6) (#1189)fix: keep literal backslash before space in link destination (CommonMark 6.3) (#1188)14.3.0 releasedBump linkify-it / vite depsfix: keep backslash-space hard line break (CommonMark 6.7) (#1185)Bump vite from 8.0.14 to 8.0.16 (#1181)Rework benchmark deps and bump versionsbenchmark => tinybenchUpdate CI configAdded package-lock and updated versions to latest possiblelint: enable @stylistic/no-multi-spaces rulelint => neostandarddemo: twbs3 => twbs5demo: update sampledemo: don't highlight src/debug tabsUpdate gitignoredemo: use highlight.js styles from node packagedemo: drop twemojidemo: remove jquery & lodash depsdemo: drop bootstrap JS dependencyUpdate publishing hooksSetup weekly tracking of pathlogicals in upstreamUse the same readme for docsDrop shelljs dependencyPort demo to vite buildAdd source maps to buildrollup => viteReduce dev depsUpdate coverage gen and uploadConvert build test to mjsjest-worker => Workermocha => native node testsReduce spec tests outputSimplify buildsSplit testsDepfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with
@depfu rebase.All Depfu comment commands