Repository navigation
feat(layout): resize and snap panes and sidebar - #83
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
voltcrash
changed the title
The sidebar resize target overlapped the pane restore button, and the rows drag test assumed an unsettled divider position. Move the sidebar target inside the sidebar and locate the divider from its actual bounds after the stacked layout is ready.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pane divider and sidebar are difficult to return to their exact default sizes by dragging, and the sidebar previously had a fixed width.
Snap the pane divider to 50/50 within 12 pixels of center. Make the desktop sidebar resizable on either side, save its width, and snap it to its original 258px width within 12 pixels. Add browser coverage for both layouts, sidebar positions, and saved sizes.