Skip to content

refactor: extract shared web app and harden validation - #124

Merged
KingDoxik merged 10 commits into
mainfrom
ci/pipeline-hardening
Aug 9, 2026
Merged

refactor: extract shared web app and harden validation#124
KingDoxik merged 10 commits into
mainfrom
ci/pipeline-hardening

Conversation

@KingDoxik

@KingDoxik KingDoxik commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Extract the reusable web application into the @voidhash/web-app source package.
  • Separate shared routes from Community-owned routes and keep the Community entrypoint thin.
  • Add typed composition seams for authentication, edition metadata, global styles, and server behavior.
  • Consolidate web build, typecheck, and component-test configuration around the shared package.
  • Harden CI with linting, integration-tier registration, release E2E coverage, and repository hygiene checks.

Why

This gives each edition explicit ownership of its pages while keeping shared product features in one open-source package. New edition-specific pages no longer require duplicating or conditionally weaving through the shared route tree.

Validation

  • Community production build passes.
  • Shared package and Community typechecks pass.
  • Web component suite passes: 68 files and 604 tests.
  • Lint passes.
  • Publication, platform-seam, self-hosting boundary, and test-tier checks pass.

- Run lint in CI: root lint script now runs the lint rules alone (vp check
  bundles the formatter, which the repo deliberately does not enforce) and
  verify:quick runs it, so Repository CI lints every PR.
- Wire packages/clickhouse-db tests into turbo test (4 files were never run).
- Quarantine apps/www component tests as test:components with the dual-React
  hoisted-install root cause documented in vite.config.ts; two files that
  crash even in a warm tree stay excluded.
- Extract scripts/integration-suites.mjs and cross-check it from
  check-test-tiers.mjs, so a package that gains integration tests without
  being registered with the runner fails verify:quick instead of silently
  never running.
- Add test:e2e:release to verify for parity with the Self-host Compose
  workflow.
- Notify the monorepo on main pushes (notify-mono.yml) so its submodule bump
  automation reacts immediately; warns and passes while MONO_DISPATCH_TOKEN
  is unset.
- Never cancel in-progress CI on main; drop the dead knip turbo task.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your trial has ended. Reactivate Greptile to resume code reviews.

@github-actions

github-actions Bot commented Aug 6, 2026

Copy link
Copy Markdown

Thank you for following the naming conventions for pull request titles! 🙏

@github-actions

github-actions Bot commented Aug 6, 2026

Copy link
Copy Markdown

Install the packages built from 66f3215:

@voidhash/paywalls

pnpm add @voidhash/paywalls@https://pkg.voidha.sh/paywalls/66f3215

@voidhash/node

pnpm add @voidhash/node@https://pkg.voidha.sh/node/66f3215

@voidhash/web

pnpm add @voidhash/web@https://pkg.voidha.sh/web/66f3215

voidhash-cli

pnpm add voidhash-cli@https://pkg.voidha.sh/cli/66f3215

@voidhash/react-native

pnpm add @voidhash/react-native@https://pkg.voidha.sh/react-native/66f3215

Internal workspace deps (lib, generated-clients, shared, studio) are published at the same sha and resolved automatically.

Replace the sha with pr-124 or the branch name to always get the latest build of this PR.

@greptile-apps

greptile-apps Bot commented Aug 8, 2026

Copy link
Copy Markdown

Too many files changed for review (1846 files, 100 file limit).

@KingDoxik KingDoxik changed the title ci: harden validation pipeline and wire dormant test suites refactor: extract shared web app and harden validation Aug 8, 2026
@KingDoxik
KingDoxik merged commit 38db600 into main Aug 9, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant