refactor: extract shared web app and harden validation - #124
Merged
Conversation
- Run lint in CI: root lint script now runs the lint rules alone (vp check bundles the formatter, which the repo deliberately does not enforce) and verify:quick runs it, so Repository CI lints every PR. - Wire packages/clickhouse-db tests into turbo test (4 files were never run). - Quarantine apps/www component tests as test:components with the dual-React hoisted-install root cause documented in vite.config.ts; two files that crash even in a warm tree stay excluded. - Extract scripts/integration-suites.mjs and cross-check it from check-test-tiers.mjs, so a package that gains integration tests without being registered with the runner fails verify:quick instead of silently never running. - Add test:e2e:release to verify for parity with the Self-host Compose workflow. - Notify the monorepo on main pushes (notify-mono.yml) so its submodule bump automation reacts immediately; warns and passes while MONO_DISPATCH_TOKEN is unset. - Never cancel in-progress CI on main; drop the dead knip turbo task. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
|
Thank you for following the naming conventions for pull request titles! 🙏 |
|
Install the packages built from 66f3215: @voidhash/paywalls pnpm add @voidhash/paywalls@https://pkg.voidha.sh/paywalls/66f3215@voidhash/node pnpm add @voidhash/node@https://pkg.voidha.sh/node/66f3215@voidhash/web pnpm add @voidhash/web@https://pkg.voidha.sh/web/66f3215voidhash-cli pnpm add voidhash-cli@https://pkg.voidha.sh/cli/66f3215@voidhash/react-native pnpm add @voidhash/react-native@https://pkg.voidha.sh/react-native/66f3215Internal workspace deps (lib, generated-clients, shared, studio) are published at the same sha and resolved automatically. Replace the sha with |
|
Too many files changed for review (1846 files, 100 file limit). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@voidhash/web-appsource package.Why
This gives each edition explicit ownership of its pages while keeping shared product features in one open-source package. New edition-specific pages no longer require duplicating or conditionally weaving through the shared route tree.
Validation