[ci skip]new package: openfoam2512#61092
Conversation
| hostmakedepends="wget" | ||
| makedepends="libfl-devel openmpi-devel gnuplot libboost_thread flex boost-devel openmpi" | ||
| depends="openmpi libboost_thread flex boost libgomp gnuplot" | ||
| short_desc="OpenFOAM is a free, open source CFD software released and developed by OpenCFD Ltd since 2004" |
There was a problem hiding this comment.
| short_desc="OpenFOAM is a free, open source CFD software released and developed by OpenCFD Ltd since 2004" | |
| short_desc="Computational Fluid Dynamics (CFD) Toolbox" |
For the description
- it doesn't matter who develops it and since when
- it doesn't matter if it's open source (if not, it would be in the
nonfreerepository anyways) - it's useless to repeat the name of the package, because the user already can see the package name anyways :)
There was a problem hiding this comment.
but there is 2 branches/forks of openfoam one is developed by OpenCFD and the other one is by the foundation. and the users will know which package is for which version with the description. and this description is what they have in there own website
There was a problem hiding this comment.
Im this case it's enough to add "developed by OpenCFD" to the description, the "2004" is still not needed :)
| build_style="" | ||
| configure_args="" | ||
| hostmakedepends="wget" |
There was a problem hiding this comment.
| build_style="" | |
| configure_args="" | |
| hostmakedepends="wget" |
| do_fetch() { | ||
| mkdir -p $wrksrc | ||
| cd $wrksrc | ||
| wget ${distfiles} | ||
| } | ||
| do_extract() { | ||
| vtar -xf "OpenFOAM-${version}.tgz" | ||
| vtar -xf "ThirdParty-${version}.tar.gz" | ||
| mv "ThirdParty-${version}" "OpenFOAM-${version}/thirdparty" | ||
| } | ||
| do_build() { | ||
| cd "OpenFOAM-${version}" |
There was a problem hiding this comment.
Why are you downloading and extracting the package yourself? xbps-src does that automatically for you
| do_fetch() { | |
| mkdir -p $wrksrc | |
| cd $wrksrc | |
| wget ${distfiles} | |
| } | |
| do_extract() { | |
| vtar -xf "OpenFOAM-${version}.tgz" | |
| vtar -xf "ThirdParty-${version}.tar.gz" | |
| mv "ThirdParty-${version}" "OpenFOAM-${version}/thirdparty" | |
| } | |
| do_build() { | |
| cd "OpenFOAM-${version}" | |
| do_build() { |
There was a problem hiding this comment.
when I do this suggestion and the previus one I get this error:
=> openfoam2512-v2512_1: fetching distfile 'OpenFOAM-v2512.tgz' from 'https://dl.openfoam.com/source/v2512/OpenFOAM-v2512.tgz'...
ERROR: xbps-fetch: failed to fetch: https://dl.openfoam.com/source/v2512/OpenFOAM-v2512.tgz: Moved Temporarily
=> ERROR: openfoam2512-v2512_1: failed to fetch 'OpenFOAM-v2512.tgz'.
can you test these suggestion ?
There was a problem hiding this comment.
Please use ${SOURCEFORGE_SITE}/openfoam/OpenFOAM-v${version}.tgz, that's where it redirects to.
Co-authored-by: Bnyro <bnyro@tutanota.com>
| @@ -0,0 +1,38 @@ | |||
| # Template file for 'openfoam2512' | |||
| pkgname=openfoam2512 | |||
| version=v2512 | |||
There was a problem hiding this comment.
The v shouldn't be part of the version.
| @@ -0,0 +1,38 @@ | |||
| # Template file for 'openfoam2512' | |||
There was a problem hiding this comment.
The package sbould be called openfoam, not openfoam2512.
There was a problem hiding this comment.
the users usually would install mutiple versions of openfoam (e.g 2512, 2412, 2606). and they expect that the 2512 version will not get updated automatically to 2606.
3 participants
this is the openfoam the .com version. here is the .org (foundation) version
Testing the changes
New package
Local build testing