-
Notifications
You must be signed in to change notification settings - Fork 3
feat(cli): add --document-dpi and --document-max-pages to vlmrun gw chat
#204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 New command options use outdated type-hint style disallowed by repo guidelines
The two new options are annotated with
Optional[int](vlmrun/cli/_cli/gateway.py:573andvlmrun/cli/_cli/gateway.py:583), but the repository's mandatory style guide requires the modernint | Noneunion syntax for all new code.Impact: The new code does not follow the repository's required modern Python type-hint style.
Rule reference in AGENTS.md
AGENTS.md, section "Modern Python Style", states: "Use
X | Noneinstead ofOptional[X]for type hints (PEP 604)." The newly added parametersdocument_dpianddocument_max_pagesuseOptional[int]instead ofint | None. Note the surrounding file already usesOptionalthroughout, so this is a pre-existing convention in the module, but the rule explicitly applies to new code.Was this helpful? React with 👍 or 👎 to provide feedback.