chore: clear residual pnpm audit advisories#12
Open
bntvllnt wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
bntvllnt
commented
May 20, 2026
Collaborator
Author
bntvllnt
left a comment
There was a problem hiding this comment.
Review — 0 blocking findings, 1 warning
BLOCKING
None.
WARN
W1 — stacked PR has no GitHub check signal until the merge target changes- Evidence: PR #12 targets
chore/flatted-3-4-2-remediation(PR #11), while.github/workflows/ci.ymlrunspull_requestonly forbranches: [main];gh pr checksreports no checks onchore/residual-pnpm-audit-remediation. - Why it matters: the local validation is good evidence for this head, but GitHub branch protection/check visibility will not cover the stacked PR until PR #11 is merged and this PR is retargeted or otherwise re-run against
main. - Suggested next step: merge/order PR #11 first, then let this PR retarget/main-run normally before final merge if repository policy requires GitHub-hosted checks.
- Evidence: PR #12 targets
VERIFIED CLEAN
- Live head checked before review:
e5ec4a7c9d0896653ddcaaaf693555d1ef1645e0; it matches the task head. - Live PR state: OPEN, non-draft, MERGEABLE/CLEAN, base
chore/flatted-3-4-2-remediation, no status checks reported. - PR body claims match the live diff: changed files are exactly
package.json,pnpm-lock.yaml, andsrc/analytics.ts; the PR is stacked on PR #11 (chore/flatted-3-4-2-remediation) and PR #11 is also OPEN/non-draft/MERGEABLE/CLEAN at51521b1daa0c28e7133c4070d19f752fa715407a. package.json: the addedpnpm.overridesare scoped to the claimed residual audit packages/clusters (@boundaries/elements,eslint-plugin-boundaries,brace-expansion,lodash,picomatch,postcss,turbo,vite,ws) and do not alter runtime package exports or scripts.pnpm-lock.yaml: lockfile is consistent with the overrides; targeted resolved versions includeflatted@3.4.2,handlebars@4.7.9,picomatch@4.0.4,lodash@4.18.1,brace-expansion@5.0.6,postcss@8.5.15,ws@8.20.1,turbo@2.9.14, andvite@8.0.13.src/analytics.ts: the removedas Record<string, unknown>casts are type-clean; the typed tutorial helper properties still flow intotrack(..., properties?: Record<string, unknown>)without changing runtime behavior.
VALIDATION
- Ran:
pnpm install --frozen-lockfile— pass. - Ran:
pnpm audit --audit-level=moderate --json— pass; audit metadata reports 0 info / 0 low / 0 moderate / 0 high / 0 critical vulnerabilities and 0 advisory keys. - Ran:
pnpm lint— pass. - Ran:
pnpm exec tsc --noEmit— pass. - Ran:
pnpm test:once— pass; 5 files passed, 118 passed + 1 expected fail. - Local checkout status after validation: clean.
Next action: approval is recommended after the PR #11 stack dependency is handled, but final APPROVE is reserved for bntvllnt/human review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pnpm audit --audit-level=moderatereports zero vulnerabilities.Relationship to PR #11
This is intentionally stacked on
chore/flatted-3-4-2-remediation/ PR #11 to preserve PR #11 as the narrow flatted-only remediation. Merge order should be PR #11 first, then this residual-audit follow-up after review.Validation
pnpm install --frozen-lockfile— passpnpm audit --audit-level=moderate --json— pass, 0 critical / 0 high / 0 moderate / 0 lowpnpm lint— passpnpm exec tsc --noEmit— passpnpm test:once— pass, 5 files passed, 118 passed + 1 expected failGitHub checks
e5ec4a7c9d0896653ddcaaaf693555d1ef1645e0.github/workflows/ci.ymlonly runspull_requestforbranches: [main], and this PR targets the PR chore(deps): bump flatted to 3.4.2 #11 branch.Safety
No merge, approval, release, force-push, credential disclosure, or external outreach performed.