Skip to content

[TEST] Trigger test: .buildkite/ change - #3007

Open
rashmigottipati wants to merge 6 commits into
mainfrom
test-trigger-buildkite-change
Open

[TEST] Trigger test: .buildkite/ change#3007
rashmigottipati wants to merge 6 commits into
mainfrom
test-trigger-buildkite-change

Conversation

@rashmigottipati

@rashmigottipati rashmigottipati commented Aug 7, 2026

Copy link
Copy Markdown
Collaborator

Test PR to verify if_changed triggers

This PR modifies a file in .buildkite/gpu-tests/ which should TRIGGER transformers tests.

Part of verifying the if_changed include/exclude pattern in #2983

@coderabbitai

coderabbitai Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 9c3e1144-2825-43be-95d1-403409d847b7

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@mergify mergify Bot added the two-reviews When a PR requires two reviews label Aug 7, 2026
@mergify

mergify Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Merge Protections

🔴 2 of 2 protections blocking · waiting on 👀 reviews

Protection Waiting on
🔴 Require one maintainer review 👀 reviews
🔴 Require two reviews 👀 reviews

🔴 Require one maintainer review

Waiting for any of

  • approved-reviews-by=HDCharles
  • approved-reviews-by=brian-dellabetta
  • approved-reviews-by=dsikka
  • approved-reviews-by=kylesayrs
  • approved-reviews-by=yiliu30
This rule is failing.

All PRs must have at least one approving review from a maintainer before merging.

  • any of:
    • approved-reviews-by=HDCharles
    • approved-reviews-by=brian-dellabetta
    • approved-reviews-by=dsikka
    • approved-reviews-by=kylesayrs
    • approved-reviews-by=yiliu30
  • #changes-requested-reviews-by = 0

🔴 Require two reviews

Waiting for

  • #approved-reviews-by >= 2
This rule is failing.

PRs labelled "two-reviews" must have at least two approving reviews before merging.

  • #approved-reviews-by >= 2
  • #changes-requested-reviews-by = 0

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the Buildkite pipeline configuration for H100 and L4 GPU tests, replacing custom bash-based file change detection with Buildkite's native 'if' and 'if_changed' syntax. It splits the 'Transformers Tests' step into separate branch and pull request steps. The feedback suggests adding 'pyproject.toml' to the 'if_changed' inclusion list to ensure that any dependency or configuration updates also trigger the tests.

Comment on lines +105 to +106
- "setup.py"
- "MANIFEST.in"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

If the project uses pyproject.toml for dependency management or project configuration, changes to it should also trigger the transformers tests to ensure that dependency updates or configuration changes do not break the tests.

        - "setup.py"
        - "pyproject.toml"
        - "MANIFEST.in"

Comment on lines +94 to +95
- "setup.py"
- "MANIFEST.in"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

If the project uses pyproject.toml for dependency management or project configuration, changes to it should also trigger the transformers tests to ensure that dependency updates or configuration changes do not break the tests.

        - "setup.py"
        - "pyproject.toml"
        - "MANIFEST.in"

@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown

👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review.

Note: This is required to complete the testing suite, please only add the label once the PR is code complete and local testing has been performed.

@rashmigottipati
rashmigottipati force-pushed the test-trigger-buildkite-change branch from 510cc28 to bdd355d Compare August 14, 2026 03:08
Signed-off-by: Rashmi Gottipati <rgottipa@redhat.com>
Signed-off-by: Rashmi Gottipati <rgottipa@redhat.com>
Signed-off-by: Rashmi Gottipati <rgottipa@redhat.com>
Signed-off-by: Rashmi Gottipati <rgottipa@redhat.com>
… regex operator

Signed-off-by: Rashmi Gottipati <rgottipa@redhat.com>
@rashmigottipati
rashmigottipati force-pushed the test-trigger-buildkite-change branch from bdd355d to 4cfbb1f Compare August 14, 2026 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

two-reviews When a PR requires two reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant