[TEST] Trigger test: src/ change - #3006
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Merge Protections🔴 2 of 2 protections blocking · waiting on 👀 reviews
🔴 Require one maintainer reviewWaiting for any of
This rule is failing.All PRs must have at least one approving review from a maintainer before merging.
🔴 Require two reviewsWaiting for
This rule is failing.PRs labelled "two-reviews" must have at least two approving reviews before merging.
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the Buildkite pipeline configurations for H100 and L4 GPU tests to use native conditional execution (if and if_changed) instead of custom bash scripts for detecting changes. However, the conditional logic uses null checks on build.pull_request (e.g., build.pull_request == null and build.pull_request != null). In Buildkite, build.pull_request evaluates to false when the build is not a pull request, meaning these checks will not behave as intended. You should update these conditionals to compare against false instead.
| - label: ":mag: Detect changes for Transformers Tests" | ||
| # Transformers tests - always run on branch pushes | ||
| - label: ":mag: Transformers Tests (branch)" | ||
| if: build.pull_request == null |
There was a problem hiding this comment.
In Buildkite, build.pull_request evaluates to false (boolean) when the build is not a pull request, rather than null. Using == null will always evaluate to false, meaning this step will never run on branch pushes.
if: build.pull_request == false|
|
||
| # Transformers tests - conditional on PRs when relevant paths changed | ||
| - label: ":mag: Transformers Tests (PR)" | ||
| if: build.pull_request != null |
There was a problem hiding this comment.
In Buildkite, build.pull_request evaluates to false (boolean) when the build is not a pull request, rather than null. Using != null will always evaluate to true, meaning this step will run on branch pushes as well.
if: build.pull_request != false| - label: ":mag: Detect changes for Transformers Tests" | ||
| # Transformers tests - always run on branch pushes | ||
| - label: ":mag: Transformers Tests (branch)" | ||
| if: build.pull_request == null |
There was a problem hiding this comment.
In Buildkite, build.pull_request evaluates to false (boolean) when the build is not a pull request, rather than null. Using == null will always evaluate to false, meaning this step will never run on branch pushes.
if: build.pull_request == false|
|
||
| # Transformers tests - conditional on PRs when relevant paths changed | ||
| - label: ":mag: Transformers Tests (PR)" | ||
| if: build.pull_request != null |
There was a problem hiding this comment.
In Buildkite, build.pull_request evaluates to false (boolean) when the build is not a pull request, rather than null. Using != null will always evaluate to true, meaning this step will run on branch pushes as well.
if: build.pull_request != false
|
👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review. Note: This is required to complete the testing suite, please only add the label once the PR is code complete and local testing has been performed. |
e1be950 to
c020f23
Compare
Signed-off-by: Rashmi Gottipati <rgottipa@redhat.com>
Signed-off-by: Rashmi Gottipati <rgottipa@redhat.com>
Signed-off-by: Rashmi Gottipati <rgottipa@redhat.com>
Signed-off-by: Rashmi Gottipati <rgottipa@redhat.com>
… regex operator Signed-off-by: Rashmi Gottipati <rgottipa@redhat.com>
c020f23 to
b1e7c13
Compare
1 participant
Test PR to verify if_changed triggers
This PR modifies a file in
src/which should TRIGGER transformers tests.Part of verifying the if_changed include/exclude pattern in #2983