[Docs] Minor fixes for sequential onloading docs - #2771
Conversation
|
👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review. Note: This is required to complete the testing suite, please only add the label once the PR is code complete and local testing has been performed. |
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughThis PR updates the sequential onloading documentation guide with two changes: correcting the pseudo-code example to show layer operations applied to ChangesSequential Onloading Guide
🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Code Review
This pull request corrects a variable name in a Python code example within the sequential onloading documentation and adds a warning regarding the use of highly granular sequential targets (such as "Linear") with NVFP4/NVFP4A16 quantization. The reviewer suggested rephrasing the warning message to improve clarity and readability.
| !!! warning | ||
| Using a highly granular sequential target such as `"Linear"` is not supported for NVFP4/NVFP4A16 quantization, which requires that fused weights (qkv, gate_up, etc.) all be a part of the same sequential target. |
There was a problem hiding this comment.
The warning message can be rephrased to improve readability and clarity. Splitting the long sentence and using more formal terms for the projections makes the documentation easier to follow.
| !!! warning | |
| Using a highly granular sequential target such as `"Linear"` is not supported for NVFP4/NVFP4A16 quantization, which requires that fused weights (qkv, gate_up, etc.) all be a part of the same sequential target. | |
| !!! warning | |
| Using a highly granular sequential target such as "Linear" is not supported for NVFP4/NVFP4A16 quantization. This format requires that fused weights (such as QKV and gate/up projections) are kept within the same sequential target. |
Merge Protections🔴 1 of 1 protections blocking · waiting on 👀 reviews
🔴 Require one maintainer reviewWaiting for any of
This rule is failing.All PRs must have at least one approving review from a maintainer before merging.
|
No description provided.