feat: add home-based configuration and tool settings - #180
Open
maralbahari wants to merge 5 commits into
Open
Conversation
Signed-off-by: maral <maralbahari.98@gmail.com>
Signed-off-by: maral <maralbahari.98@gmail.com>
Signed-off-by: maral <maralbahari.98@gmail.com>
…ainer restarts Signed-off-by: maral <maralbahari.98@gmail.com>
maralbahari
marked this pull request as ready for review
August 14, 2026 10:03
maralbahari
requested review from
bbrowning,
franciscojavierarceo,
jiahuei,
leseb,
noobHappylife,
qandrew and
tjtanaa
as code owners
August 14, 2026 10:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AGENTIC_API_HOMEand defaulting to~/.agentic-api.$AGENTIC_API_HOME/agentic_api.db.config.tomlloading and first-run generation:0640permissions on Unix (group-readable so a container restart under arotated arbitrary UID sharing the image's root group can still read it);
llm_api_baseanddatabase_url;[web_search]provider URL andapi_key_env;[mcp]request-declared host allowlists;[mcp_servers.<label>];allowed_toolsandrequire_approval;server_label.allowed_toolsas a policy ceiling:server_url.example, attempting to override a gateway-configured server's
server_url), instead ofsilently absorbing it into per-server discovery-failure metadata, which could otherwise leave
tool_choicepointed at zero available tools and surface as an opaque upstream error./var/lib/agentic-apiasAGENTIC_API_HOME.scripts/smoke-mcp.sh, which verifies MCP discovery and completedsay_helloandsumcalls through a running gateway.The default database location is a behavior change. Existing databases in the working directory are not moved automatically; deployments can continue using them by setting
DATABASE_URLexplicitly.Test Plan
cargo test -- --test-threads=2passes across the workspace (357 passed / 3 ignoredPostgres-only in
agentic-server-core, plus all other crates).agentic-server-core::tool::registryunit tests that combined agateway-configured MCP server with a request declaration that also set
server_url;updated their fixtures to declare the configured path by
server_labelalone, matchingthe policy-ceiling behavior this PR adds.
override a configured server's
server_url) fails the request immediately instead ofbeing silently absorbed into discovery-failure metadata.
cargo test -p agentic-server-core --test mcp_tool_test(8/8) after re-recording thegateway MCP cassettes; gateway output still matches the OpenAI reference cassettes.
docker buildsucceeds end-to-end (release compile stage + Debian runtime stage).