fix: judge tombstone drops over the whole compaction range - #15
Merged
xRookieFight merged 1 commit intoSep 26, 2026
Merged
Conversation
Contributor
Author
|
@xRookieFight review 🤣 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
A compaction may drop a delete marker when no deeper level holds that key.
It checked only the range of its input files, but it also rewrites whole files pulled in from the next level which can cover much more.
So an L1 input covering
b…cpulls in an L2 file coveringa…z, the deletemarker for
yinside it gets dropped and an olderyin L3 comes back.It now checks the range of every file it rewrites. Fewer delete markers are
dropped, never more.
How it was checked
Checklist