Skip to content

fix: judge tombstone drops over the whole compaction range - #15

Merged
xRookieFight merged 1 commit into
vlang:masterfrom
bedrock-v:fix/compaction-tombstone-range
Sep 26, 2026
Merged

xRookieFight merged 1 commit into
vlang:masterfrom
bedrock-v:fix/compaction-tombstone-range

Conversation

@nepinhum

Copy link
Copy Markdown
Contributor

What this changes

A compaction may drop a delete marker when no deeper level holds that key.
It checked only the range of its input files, but it also rewrites whole files pulled in from the next level which can cover much more.

So an L1 input covering b…c pulls in an L2 file covering a…z, the delete
marker for y inside it gets dropped and an older y in L3 comes back.

It now checks the range of every file it rewrites. Fewer delete markers are
dropped, never more.

How it was checked

v fmt -verify .
v vet .
v test .
v run examples/smoke

Checklist

  • v fmt -w . ran
  • Tests pass
  • A new module carries a README.md

@nepinhum

Copy link
Copy Markdown
Contributor Author

@xRookieFight review 🤣

@xRookieFight xRookieFight left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@xRookieFight
xRookieFight merged commit b1c09bd into vlang:master Sep 26, 2026
4 checks passed
@xRookieFight
xRookieFight deleted the fix/compaction-tombstone-range branch September 26, 2026 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants