fix: close the recovery crash window that lost WAL recovered data - #14
Merged
Merged
Conversation
xRookieFight
approved these changes
Sep 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Open published the new journal number in the manifest before the recovered memtable reached a table.
Once CURRENT named that manifest, recovery skipped every older journal and a crash in between lost the
recovered data while its journal was still on disk. The table is now written first and one manifest record names
both it and the new journal. A crash before that record leaves the old manifest, which still names the old journal,
and the next open replays it.
Open also no longer rotates the journal twice since the recovery flush it used to call did that itself.
mark_file_num_usedkeeps the file number allocator past a journal that an earlier open created but never recorded, matching upstream'sMarkFileNumberUsed. Such a journal otherwise kept its number in use on disk where the manifest could hand it out again and stayed above every later journal number. Recovery replayed it on every open and never removed it.How it was checked