Conversation
CMake 4.x removed compatibility with cmake_minimum_required values below 3.5, so configuring with a modern CMake (e.g. on Ubuntu 26.04) fails with: Compatibility with CMake < 3.5 has been removed from CMake.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CMake 4.x has removed compatibility with
cmake_minimum_requiredvalues below 3.5, so configuring grive2 with a modern CMake (e.g. on Ubuntu 26.04, which ships CMake 4.2) fails with:This bumps the minimum required version to 3.5 so the project configures cleanly under CMake 4.x while still supporting older CMake releases (3.5 was released in 2016).
Test plan
cmakeconfigures successfully on Ubuntu 26.04 with CMake 4.2.3makebuildsgrive,libgrive.a,btest, andunittestto completiongrive version 0.5.3Note: a fully clean build on Ubuntu 26.04 also requires the changes from #403 (libgcrypt pkg-config fallback) and #410 (Boost 1.89+ no longer ships
boost::systemas a separate library). This PR intentionally only addresses the CMake version bump to keep it focused.