Skip to content

fix(web): portal the create-vault dialog out of the transformed sidebar #350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vineethkrishnan merged 1 commit into from
Aug 11, 2026
Merged

fix(web): portal the create-vault dialog out of the transformed sidebar #350

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions web/src/components/vault/CreateVaultDialog.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
// SPDX-License-Identifier: AGPL-3.0-or-later

import { useEffect, useRef, useState } from "react";
import { createPortal } from "react-dom";
import { useTranslation } from "react-i18next";
import { useNavigate } from "@tanstack/react-router";
import { useQuery, useQueryClient } from "@tanstack/react-query";
Expand Down Expand Up @@ -73,7 +74,9 @@ export function CreateVaultDialog({ onClose }: Props) {
}
}

return (
// Portaled like ConfirmDialog: the sidebar ancestor carries a transform for
// the mobile drawer, which would otherwise trap this fixed overlay inside it.
return createPortal(
<div
className="fixed inset-0 z-50 flex items-center justify-center bg-black/50 p-4"
onMouseDown={(e) => {
Expand Down Expand Up @@ -193,6 +196,7 @@ export function CreateVaultDialog({ onClose }: Props) {
</div>
</form>
</div>
</div>
</div>,
document.body,
);
}