Conversation
v4.0.0 swaps the internal Tus client (ankitpokhrel/tus-php) for a lightweight in-tree implementation. The Vimeo class's public surface — constructor signature, request(), upload() — is unchanged, so the wrapper needs no source changes. Existing tests and psalm pass against 4.0.1. Closes #114
ruddell
marked this pull request as ready for review
April 27, 2026 14:22
|
Thank you so much for the changes. |
|
Any way to merge this small change soon ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v4.0.0 swaps the internal Tus client (ankitpokhrel/tus-php) for a lightweight in-tree implementation. The Vimeo class's public surface — constructor signature, request(), upload() — is unchanged, so the wrapper needs no source changes. Existing tests and psalm pass against 4.0.1.
Closes #114
Note
Low Risk
Low risk: the only change is a relaxed dependency constraint, though consumers may see behavior differences when resolving to
vimeo/vimeo-apiv4.Overview
Allows this package to be installed with
vimeo/vimeo-api^4.0by widening the version constraint incomposer.json(from^3.0to^3.0|^4.0).Reviewed by Cursor Bugbot for commit e007483. Bugbot is set up for automated code reviews on this repo. Configure here.