Fix DuckLake query startup with an empty catalog - #92
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #89.
What changed
publicschema before setting the query search path.streambed.mainwhile the catalog is empty.streambed.publiconce the writer creates it.Why
DuckDB rejects a search path containing a nonexistent catalog schema. A fresh DuckLake catalog has
main, while Streambed createspubliconly after the first PostgreSQL relation is flushed. The previous unconditional search path madesync --target-format=ducklake --query-addr=...fail during startup.Validation
Both pass. The regression test starts the query server before
publicexists, flushes the first table through the writer, then verifies an unqualified query resolves it without recreating the server.