Use DuckDB for the default DuckLake catalog - #91
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: dbe136d9d4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| TargetFormat: "iceberg", | ||
| DuckLakeCatalog: defaultDuckLakeCatalogPath(), | ||
| DuckLakeCatalogStore: "sqlite", | ||
| DuckLakeCatalogStore: "duckdb", |
There was a problem hiding this comment.
Keep the CDC oracle on a compatible catalog store
The required integration-smoke workflow runs TestCDCDataIntegrityOracle, whose DuckLake sync subprocess passes a catalog path but no store, so this new default makes the subprocess create a native DuckDB catalog. Its checkpoint reader concurrently opens the same path with an empty internal ducklake.Config.CatalogStore, which normalizes to SQLite; the first checkpoint therefore cannot attach the catalog (and switching that reader to DuckDB would encounter DuckDB's cross-process writer lock). Explicitly keep this live-reader test on SQLite or restructure it so the writer is stopped before opening a native DuckDB reader.
Useful? React with 👍 / 👎.
Closes #90.
What changed
sqlitetoduckdb.~/.streambed/ducklake-catalog.duckdb.Upgrade behavior
This is an intentional default change rather than an automatic migration. Existing installations that used the previous implicit SQLite catalog must explicitly configure both legacy values:
--ducklake-catalog="$HOME/.streambed/ducklake-catalog.sqlite" \ --ducklake-catalog-store=sqliteStreambed does not convert or overwrite the old catalog. Explicit CLI flags and
STREAMBED_DUCKLAKE_CATALOG*environment variables continue to override defaults.Validation
The generated CLI help reports
.duckdbandduckdbas the defaults.