Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ jobs:
- name: Integration smoke tests
run: >
go test -tags integration -short -v -timeout 8m
-run 'TestEndToEnd$|TestEndToEndUpdateDelete$|TestSchemaEvolution_AddColumn$|TestMutationModesDuckDBCorrectness/cow$'
-run 'TestEndToEnd$|TestEndToEndUpdateDelete$|TestSchemaEvolution_AddColumn$|TestMutationModesDuckDBCorrectness/cow$|TestCDCDataIntegrityOracle$'

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Run the CDC oracle outside the slash-split regexp

In the inspected integration-smoke command, the new oracle is never selected. go help testflag states that -run expressions are split at each unbracketed /; consequently, TestCDCDataIntegrityOracle$ becomes part of the second, subtest-name expression, while the top-level test must match the first expression ending at TestMutationModesDuckDBCorrectness. Run the oracle separately or escape/bracket the slash so the complete expression is not split.

Useful? React with 👍 / 👎.

./test/integration

- name: Query compatibility oracle
Expand Down
Loading
Loading