Repository navigation
chore(deps): upgrade whatsmeow and adapt to DownloadMediaWithPathToFile signature change - #23
Merged
Conversation
…le signature change whatsmeow 2026-03-27 -> 2026-07-20 (plus transitive upgrades). DownloadMediaWithPathToFile dropped its fileLength parameter and gained an allowNoHash bool before the file argument; internal/client adapts to the new signature.
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
whatsmeow on
mainis ~4 months behind. Bumping it pulls the usual transitive updates and breaks exactly one call site:DownloadMediaWithPathToFiledropped itsfileLength intparameter and addedallowNoHash boolbeforefile.We pass
allowNoHash=false, which preserves hash verification — and is fail-closed: with it set, whatsmeow substitutes a zero hash whenfileSHA256is nil, so a payload supplyingmediaKey+directPath+fileEncSHA256but omittingfileSHA256fails verification rather than silently skipping it.The dropped
fileLengthwas only used in aReturnDownloadWarnings-gated size comparison after download, never as a streaming bound, so there is no integrity regression — content is still covered by the HMAC and SHA-256 over decrypted bytes.go build ./...,go test ./...andgo test -race ./...all pass.