S-135066: Upgrades commons lang to address vulnerabilities#73
Open
isaacsatish wants to merge 2 commits into
Open
S-135066: Upgrades commons lang to address vulnerabilities#73isaacsatish wants to merge 2 commits into
isaacsatish wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates dependency versions and refactors the codebase to replace the deprecated
org.apache.commons.langlibrary withorg.apache.commons.lang3. It also standardizes exception handling by replacingNullArgumentExceptionwithIllegalArgumentExceptionthroughout the code. These changes improve maintainability, compatibility, and error reporting.Dependency upgrades and modernization:
pom.xmlto newer versions, includinghttpclient,httpcore,commons-io,commons-lang3,org.json, andjunit. Removed deprecated dependencies and switched to version properties for easier management. [1] [2] [3]Refactoring for library migration:
org.apache.commons.langwithorg.apache.commons.lang3in source and test files, updating relevant usages (such asStringUtils,ArrayUtils, andDateUtils). [1] [2] [3] [4] [5] [6]Exception handling improvements:
NullArgumentExceptionwithIllegalArgumentExceptionfor argument validation in constructors and methods, improving standardization and clarity of error messages. This includes updates inAttributeDefinition.java,Services.java,V1Configuration.java, and corresponding test assertions. [1] [2] [3] [4] [5] [6] [7]Let me know if you have questions about any of these changes!