Repository navigation
feat(timer): show a branded alert that stays until dismissed - #648
Merged
aversini merged 1 commit intoAug 14, 2026
Merged
Conversation
When the timer finished, macOS showed a banner carrying the generic Script Editor icon, because a notification is attributed to whichever app posted it and `osascript` is owned by Script Editor. There is no parameter to override that icon. On macOS the timer now raises a dialog instead. `display dialog` takes an arbitrary image, which is the only way to escape the Script Editor icon, and it stays on screen until acknowledged rather than fading after a few seconds. That also survives Focus modes and screen sharing, both of which silently suppress banners. The dialog is spawned detached and unref'd, so the CLI exits immediately and never blocks anything chained behind it. `display dialog` has no sound parameter, so the alert sound is played alongside it via a backgrounded `afplay`. Pass `--banner` for the old passive notification. Linux (`notify-send`) and Windows (toast) are unchanged and always use their native banner. Consumer impact: the macOS default changes from a banner to a dialog; `--banner` restores the previous behaviour. `NotifyCommand` gained a required `detached` field, and detaching means `notify()` can no longer report delivery for the alert path — it resolves true on release, which is all a best-effort courtesy needs to report. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EsRJCdUiefZVC2ckCbqKJ7
aversini
deleted the
feat_timer_show_a_branded_alert_that_stays_until_dismissed
branch
August 14, 2026 03:17
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
When the timer finished, macOS showed a banner carrying the generic Script Editor icon — a notification is attributed to whichever app posted it, and
osascriptis owned by Script Editor. There is no parameter to override that icon.On macOS the timer now raises a dialog instead:
display dialogtakes an arbitrary image, which is the only way to escape the Script Editor icon.Pass
--bannerfor the old passive notification. Linux (notify-send) and Windows (toast) are unchanged and always use their native banner.Implementation notes
unref'd, so the CLI exits immediately and never blocks anything chained behind it (timer 25m && make deploystill works).spawnreports failure through an asyncerrorevent, and an unhandled one is thrown — that would crash the timer the same way the old EBADARCH regression did. A no-op handler guards it, with a test pinning the behaviour.display dialoghas no sound parameter, so the alert sound is played alongside it via a backgroundedafplay.assets/hourglass.png, rendered once from the committedassets/hourglass.svg. No build-time dependency;assetswas added tofilesand the tarball contents were verified withnpm pack --dry-run.import.meta.url, which works unchanged fromsrcanddistsince they sit at the same depth.Consumer impact
--bannerrestores the previous behaviour.NotifyCommandgained a requireddetachedfield.notify()can no longer report delivery for the alert path — it resolvestrueon release, which is all a best-effort courtesy needs to report.Verification
tscand the build pass.node dist/timer.js 4sexited at 5.2s while the dialog was still on screen at 7s, confirming it does not block.--bannerproduces the old banner.osascript display notificationshowed nothing under the same conditions.Also fixes a typo in the README, which told you to run
search --help.🤖 Generated with Claude Code
https://claude.ai/code/session_01EsRJCdUiefZVC2ckCbqKJ7