Repository navigation
build: bump @types/better-sqlite3 to 9.6.0 - #630
Merged
Merged
Conversation
The runtime better-sqlite3 dependency is already on latest (13.0.2); only the types package was behind, at 7.6.13. Despite the 7 -> 9 major jump, index.d.ts is byte-identical between the two versions (same md5). The DefinitelyTyped majors here rotate the supported TypeScript window, not the API surface: 7.6.13 is tagged ts5.1-ts5.6, while 9.6.0 covers ts5.7 through ts6.0. Since this repo builds with TypeScript 6.0.3, it was pinned to a types package outside its supported window. The lockfile churn is a de-duplication, not a new dependency: main already carried both @types/node 26.0.1 and 26.1.2, and re-resolution collapses the @inquirer/* peer keys onto the 26.1.2 that was already present, dropping the now-orphaned 26.0.1 entry. Verified from a clean install: build 14/14, test 12/12, lint 13/13, plus an end-to-end bundlecheck run exercising the sqlite cache write, persist and read-back path. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VhbokH2UsHWYnDBzSgk2nE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
better-sqlite3itself is already on latest (13.0.2) — no runtime bump was needed. The only drift was the types package, sitting at7.6.13.Why the major jump is a non-event
Despite the
7 → 9version gap,index.d.tsis byte-identical between the two versions (same md5,d9be334a…). Zero API surface change.The DefinitelyTyped majors here rotate the supported TypeScript window, not the library API. The dist-tags make it explicit:
7.6.13ts5.1–ts5.69.6.0ts5.7–ts6.0This repo builds with TypeScript 6.0.3, so it was pinned to a types package outside its declared support window. This bump corrects that.
About the lockfile diff
The ~155 lockfile lines are a de-duplication, not a new dependency.
mainalready carried both@types/node26.0.1and26.1.2. Re-resolution collapses the@inquirer/*peer keys onto the26.1.2that was already present and drops the now-orphaned26.0.1entry — removing a duplicate@types/nodetree, which is a net win for type resolution.Verification
Validated from a clean, from-scratch install in an isolated worktree (an incremental install in a warm working copy leaves a stale hoist layout and gives a misleading failure):
build— 14/14 projectstest— 12/12 projectslint— 13/13 projectsbundlecheckrun against the real CLI: cache read hit, forced fresh analysis ofnanoid@5.1.7, and confirmed the row persisted to~/.bundlecheck/cache.dband was served from cache on re-run — full sqlite write → persist → read round trip.Note
Kept as
build:so release-please does not cut a release — this is a devDependency-only change with no effect on published output.🤖 Generated with Claude Code
https://claude.ai/code/session_01VhbokH2UsHWYnDBzSgk2nE