Repository navigation
build: move to the two-package dev-dependency layout - #618
Merged
Merged
Conversation
dev-dependencies collapsed its four bundles into two: common (the baseline plus the shared @types) and client (the browser toolchain). This repo has no browser-facing code, so it now pins common alone. common 12.0.0 -> 13.0.0 server, types -> dropped That is the point of the restructure for this repo: server existed mainly to hold @swc/*, which is now baseline, and pinning client was never wanted. It no longer installs rsbuild, tailwind, testing-library or happy-dom at all. barrelsby left the bundles and is used by the build:barrel script in twelve packages here, so it is declared at the root — pnpm puts the root .bin on PATH for every workspace script, which is how the bundle supplied it before. lint, test and build all pass; build:barrel runs inside the build gate, so barrelsby is genuinely exercised. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01X6DpUPA4ofQeXDyLbhPzdW
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Step 2 of the dev-dependencies restructure (versini-org/dev-dependencies#872), repointing this repo at the new layout.
Pins
dev-dependenciescollapsed four bundles into two —common(baseline tooling + the shared@types/*) andclient(the browser toolchain).serverandtypesare gone:serverwas 9-of-13 duplicated inclient, andtypesis wanted wherever TypeScript runs.commonclientserver,typesPackages that left the bundles
Seven packages were used by only one or two repos, so they're now declared by the repos that use them instead of shipped to everyone. Whatever this repo actually uses is declared in the same commit as the pin change, so no install ever sees a half-migrated state.
Placement rule: binaries invoked in scripts → repo root (pnpm puts the root
.binon PATH for every workspace script, which is exactly how the bundle supplied them); imported modules → the package that imports them (module resolution needs it local).Two of the seven —
prettierandrollup— are deliberately not re-added anywhere. Both turned out to be unused ecosystem-wide: everyprettierscript runsbiome check --write(the name is a leftover from before the biome migration), and therolluphits arerollup-plugin-copyand Vite'srollupOptionsconfig key.Verification
lint,test, andbuildall pass (plustypecheckwhere this repo has one).Anything added here was checked to actually resolve — including the cases the gates don't reach, since
devscripts aren't run by any gate.🤖 Generated with Claude Code
https://claude.ai/code/session_01X6DpUPA4ofQeXDyLbhPzdW