Repository navigation
Conversation
Add BROWSER_FRAMEWORK_DEPS and use it during platform auto-detection so packages that declare engines.node but depend on browser frameworks (react, vue, svelte, etc.) are treated as browser packages. Update bundler logic to inspect dependencies and peerDependencies and prefer node only when no browser framework deps are present. Add tests covering react, vue, svelte in deps/peerDeps and a fallback case for pure node packages.
aversini
deleted the
fix(bundlecheck)-treat-browser-framework-deps-as-browser-platform
branch
February 14, 2026 01:09
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add BROWSER_FRAMEWORK_DEPS and use it during platform auto-detection so packages that declare engines.node but depend on browser frameworks (react, vue, svelte, etc.) are treated as browser packages. Update bundler logic to inspect dependencies and peerDependencies and prefer node only when no browser framework deps are present. Add tests covering react, vue, svelte in deps/peerDeps and a fallback case for pure node packages.