Repository navigation
fix(bundlecheck): Store and use actual_externals in cache - #494
Merged
aversini merged 1 commit intoFeb 1, 2026
Merged
Conversation
Add an actual_externals column to the bundle_cache schema (with migration) and persist computed externals when caching results. getCachedResult now prefers actual_externals (falling back to legacy externals) and setCachedResult stores sorted actual_externals. A test was added to ensure cached results return the computed externals (e.g. auto-detected react/react-dom) when the cache key externals differ from the result externals. Backwards compatibility for older cache rows is preserved.
aversini
deleted the
fix(bundlecheck)-Store-and-use-actual_externals-in-cache
branch
February 1, 2026 16:00
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an actual_externals column to the bundle_cache schema (with migration) and persist computed externals when caching results. getCachedResult now prefers actual_externals (falling back to legacy externals) and setCachedResult stores sorted actual_externals. A test was added to ensure cached results return the computed externals (e.g. auto-detected react/react-dom) when the cache key externals differ from the result externals. Backwards compatibility for older cache rows is preserved.