Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 50 additions & 0 deletions packages/bundlecheck/src/__tests__/trend.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,56 @@ describe("selectTrendVersions", () => {
const result = selectTrendVersions([]);
expect(result).toEqual([]);
});

it("should filter out canary versions", () => {
const versions = [
"19.3.0-canary-abc123",
"19.2.4",
"19.2.3",
"19.2.0-canary-xyz789",
"19.2.2",
];
const result = selectTrendVersions(versions, 3);
expect(result).toEqual(["19.2.4", "19.2.3", "19.2.2"]);
});

it("should filter out alpha versions", () => {
const versions = ["2.0.0-alpha.1", "1.2.0", "1.1.0-alpha.2", "1.0.0"];
const result = selectTrendVersions(versions, 3);
expect(result).toEqual(["1.2.0", "1.0.0"]);
});

it("should filter out beta versions", () => {
const versions = ["3.0.0-beta.1", "2.0.0", "1.5.0-beta.2", "1.0.0"];
const result = selectTrendVersions(versions, 3);
expect(result).toEqual(["2.0.0", "1.0.0"]);
});

it("should filter out rc versions", () => {
const versions = ["3.0.0-rc.1", "2.0.0", "1.5.0-rc.2", "1.0.0"];
const result = selectTrendVersions(versions, 3);
expect(result).toEqual(["2.0.0", "1.0.0"]);
});

it("should filter out all prerelease types mixed together", () => {
const versions = [
"5.0.0-canary.1",
"4.0.0-alpha.1",
"3.0.0-beta.1",
"2.0.0-rc.1",
"1.2.0",
"1.1.0",
"1.0.0",
];
const result = selectTrendVersions(versions, 3);
expect(result).toEqual(["1.2.0", "1.1.0", "1.0.0"]);
});

it("should return empty array if all versions are prereleases", () => {
const versions = ["2.0.0-canary.1", "1.5.0-alpha.1", "1.0.0-beta.1"];
const result = selectTrendVersions(versions, 3);
expect(result).toEqual([]);
});
});

describe("renderTrendGraph", () => {
Expand Down
8 changes: 6 additions & 2 deletions packages/bundlecheck/src/trend.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import { Logger } from "@node-cli/logger";
import kleur from "kleur";
import { prerelease } from "semver";
import { checkBundleSize, formatBytes } from "./bundler.js";
import { TREND_VERSION_COUNT } from "./defaults.js";

Expand All @@ -21,13 +22,16 @@ export type TrendOptions = {

/**
* Select versions for trend analysis
* Returns the most recent versions (newest first)
* Returns the most recent stable versions (newest first)
* Filters out prerelease versions (canary, alpha, beta, rc, etc.)
*/
export function selectTrendVersions(
allVersions: string[],
count: number = TREND_VERSION_COUNT,
): string[] {
return allVersions.slice(0, count);
// Filter out prerelease versions (canary, alpha, beta, rc, etc.)
const stableVersions = allVersions.filter((v) => !prerelease(v));
return stableVersions.slice(0, count);
}

/**
Expand Down