INT-8628: Make intercom vstream socket path and stream number configurable - #13
Merged
darshan-verkada merged 1 commit intoApr 3, 2026
Conversation
![semgrep-code-verkada[bot]](https://avatars.githubusercontent.com/u/25538373?s=60&v=4){kind=small}
MattMacGregor
self-requested a review
April 3, 2026 01:14
darshan-verkada
changed the base branch from
feature/INT-8910-srv-resolved-callback
to
intercom/release-2-15
April 3, 2026 18:34
|
Sorry what is the stream num for? My understanding is we were just switching from a hardcoded port to a hardcoded unix socket. |
Replace compile-time defines with runtime config passed through pjsua_media_config so the application controls where video frames come from and which stream to use for IDR requests, without recompiling the library. - Switch intercom_codec socket_init() from TCP port 20001 to Unix domain socket - Add vstream_sock_path (char[256]) and vstream_stream_num (unsigned) to pjsua_media_config; defaults are empty/sentinel to force explicit app config - Update pjmedia_codec_intercom_vid_init() signature to accept the two values; validate with PJ_ASSERT_RETURN — PJ_EINVAL if either is unset - Add runtime guard in socket_init() as a second line of defense - Mirror fields in pjsua2 MediaConfig (vstreamSockPath, vstreamStreamNum) with fromPj/toPj/readObject/writeObject support - Pass values from pjsua_var.media_cfg in pjsua_vid.c Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
darshan-verkada
force-pushed
the
feature/INT-8628-vstream-configurable
branch
from
April 3, 2026 18:40
8fc96a6 to
e5c10d1
Compare
MattMacGregor
approved these changes
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
intercom_codecsocket_init()from TCP port 20001 to Unix domain socketvstream_sock_path(char[256]) andvstream_stream_num(unsigned) topjsua_media_config; defaults are empty/sentinel to require explicit app configurationpjmedia_codec_intercom_vid_init()to accept the two values; validate withPJ_ASSERT_RETURN— returnsPJ_EINVALif either is unsetsocket_init()as a second line of defenseMediaConfig(vstreamSockPath,vstreamStreamNum) with fromPj/toPj/readObject/writeObject supportpjsua_var.media_cfginpjsua_vid.cTest plan
vstreamSockPathandvstreamStreamNuminvendpoint.cpp, verify video streams correctlypjsua_init()fails withPJ_EINVALif either field is left at default sentinel🤖 Generated with Claude Code