Skip to content

ESLint Auto lint check before commit - #4456

Merged
MuhammadKhalilzadeh merged 3 commits into
developfrom
mo-383-aug-12-auto-lint-check
Aug 12, 2026
Merged

ESLint Auto lint check before commit#4456
MuhammadKhalilzadeh merged 3 commits into
developfrom
mo-383-aug-12-auto-lint-check

Conversation

@MuhammadKhalilzadeh

@MuhammadKhalilzadeh MuhammadKhalilzadeh commented Aug 12, 2026

Copy link
Copy Markdown
Collaborator

ESLint Auto lint check before commit

Please ensure all items are checked off before requesting a review:

  • I deployed the code locally.
  • I have performed a self-review of my code.
  • I have included the issue # in the PR.
  • I have labelled the PR correctly.
  • The issue I am working on is assigned to me.
  • I have avoided using hardcoded values to ensure scalability and maintain consistency across the application.
  • I have ensured that font sizes, color choices, and other UI elements are referenced from the theme.
  • My pull request is focused and addresses a single, specific feature.
  • If there are UI changes, I have attached a screenshot or video to this PR.
  • If I added or modified an API endpoint, the change is reflected in the generated OpenAPI spec (npm run generate:swagger).
  • If the endpoint requires authentication, it uses authenticateJWT and the generated spec declares bearerAuth security.
  • I ran npm run check:api-drift and committed the regenerated swagger.yaml and endpoints.ts.
  • If this PR adds or modifies an organization-scoped table, the tenant isolation registry and test matrix are updated. See the tenant isolation runbook for details.

@MuhammadKhalilzadeh
chore(lint): enable eslint --fix + prettier in pre-commit for both wo…
ba911fd 
…rkspaces

- Update .husky/pre-commit to run lint-staged in Servers and Clients.
- Add Servers ESLint config, lint scripts, and lint-staged eslint --fix step.
- Fix remaining Servers ESLint errors (rls.middleware triple-slash ref,
  frameworkSelection no-unused-expressions ternaries, Object->object types).
- Add Clients lint-staged config and ensure eslint/lint-staged deps present.
- Pin Clients typescript to real 5.x so typescript-eslint loads correctly.
@MuhammadKhalilzadeh MuhammadKhalilzadeh self-assigned this Aug 12, 2026
@MuhammadKhalilzadeh MuhammadKhalilzadeh added this to the 2.5 milestone Aug 12, 2026
@github-actions

github-actions Bot commented Aug 12, 2026

Copy link
Copy Markdown

✅ Coverage Gate Passed

All coverage thresholds are met.

@MuhammadKhalilzadeh
MuhammadKhalilzadeh merged commit e25803f into develop Aug 12, 2026
22 checks passed
@MuhammadKhalilzadeh
MuhammadKhalilzadeh deleted the mo-383-aug-12-auto-lint-check branch August 12, 2026 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HarshP4585 HarshP4585 Awaiting requested review from HarshP4585

Assignees

@MuhammadKhalilzadeh MuhammadKhalilzadeh

Labels

ci/cd

Projects

None yet

Milestone

2.5

Development

Successfully merging this pull request may close these issues.

1 participant

@MuhammadKhalilzadeh