Refactor/project datasets split - #4439
Merged
Merged
Conversation
Move static download-example JSON into ProjectDatasets/exampleDatasetPayloads.ts so the page stays focused on orchestration. Co-authored-by: Cursor <cursoragent@cursor.com>
Move the upload instructions modal (turn type, use case, JSON preview, download example) into ProjectDatasets/UploadDatasetModal.tsx. Co-authored-by: Cursor <cursoragent@cursor.com>
Move the add-dataset choice and format-selection modals into a dedicated component to continue splitting the oversized ProjectDatasets page. Co-authored-by: Cursor <cursoragent@cursor.com>
Move read-only My datasets and Templates preview drawers into ProjectDatasets/ with expand state kept on the template drawer. Co-authored-by: Cursor <cursoragent@cursor.com>
Move DatasetInlineEditor, PromptEditDrawer, MyDatasetsTab, TemplatesTab, shared types, and dataset loaders/filters/CRUD into ProjectDatasets/, leaving the parent as composition. Co-authored-by: Cursor <cursoragent@cursor.com>
Force nanoid@3 to 3.3.17 and nanoid@5 to 5.1.16 so the frontend audit gate passes GHSA-28wg-ghj8-5hjv and GHSA-2v37-7h3g-55p8. Co-authored-by: Cursor <cursoragent@cursor.com>
✅ Coverage Gate PassedAll coverage thresholds are met. |
Install presidio-anonymizer with --no-deps so E2E can keep cryptography>=50 while Presidio still caps it below 49. Co-authored-by: Cursor <cursoragent@cursor.com>
…conflict" This reverts commit 2a10d01.
Co-authored-by: Cursor <cursoragent@cursor.com>
MuhammadKhalilzadeh
approved these changes
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
ProjectDatasetspage (~3.5k lines) into focused modules underProjectDatasets/, leaving the parent as composition + hook wiring.Write your issue number after "Fixes "
Fixes #4438
Please ensure all items are checked off before requesting a review:
npm run generate:swagger).authenticateJWTand the generated spec declaresbearerAuthsecurity.npm run check:api-driftand committed the regeneratedswagger.yamlandendpoints.ts.