Repository navigation
fix(core): infer s.any() fields as any - #390
Merged
Merged
Conversation
InferSpecField mapped SchemaType<"any"> to unknown, so catalog.validate() data with a visible: s.any() field was not assignable to Spec and needed an as unknown as Spec cast. Co-Authored-By: Trevin Chow <trevin@trevinchow.com>
Contributor
ctate
self-requested a review
October 7, 2026 19:37
ctate
reviewed
Oct 8, 2026
ctate
requested changes
Oct 8, 2026
core had no check-types script, so turbo skipped it and reverting the s.any() inference fix still passed CI. A focused tsconfig checks src/schema.test.ts; the full core project still fails tsc on main (TS6059, test-only errors).
ctate
approved these changes
Oct 12, 2026
Merged
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
InferSpecFieldmappedSchemaType<"any">tounknown, so the data returned bycatalog.validate()was not assignable toSpecwhenever the schema had a field likevisible: s.any(). Callers needed anas unknown as Speccast. It now infers asany, matchingz.any().Adds a test in
schema.test.tsthat assigns validated data toSpec. It failstscwithout the fix.Fixes #251. Recreates #254 by @tmchow, credited as co-author.