Skip to content

fix(core): reject partial and empty numeric strings - #389

Merged
Railly merged 1 commit into
mainfrom
railly/numeric-validator-strict
Oct 12, 2026
Merged

Railly merged 1 commit into
mainfrom
railly/numeric-validator-strict

Conversation

@Railly

@Railly Railly commented Oct 7, 2026

Copy link
Copy Markdown
Member

The numeric validator used parseFloat, so "123abc" and "99bottles" passed as valid numbers. Switching to Number() alone would let "" and whitespace-only strings pass, since both coerce to 0. The validator now requires a non-empty string that Number() parses fully, with tests for both cases.

Recreates the numeric half of #306 by @fix2015, credited as co-author. The $truncate half changes documented behavior (existing tests expect the suffix after length), so it is left out of this PR.

parseFloat accepted "123abc" as 123, and Number() alone treats "" and whitespace as 0. Require a non-empty string that Number() parses fully.

Co-Authored-By: vitalii.semianchuk <fix20152@gmail.com>
@vercel

vercel Bot commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
json-render Ready Ready Preview, v0 Oct 7, 2026 5:04pm UTC
json-render-chat-demo Ready Ready Preview, v0 Oct 7, 2026 5:04pm UTC
json-render-dashboard-demo Ready Ready Preview, v0 Oct 7, 2026 5:04pm UTC
json-render-game-engine-demo Ready Ready Preview, v0 Oct 7, 2026 5:04pm UTC
json-render-image-demo Ready Ready Preview, v0 Oct 7, 2026 5:04pm UTC
json-render-no-ai Ready Ready Preview, v0 Oct 7, 2026 5:04pm UTC
json-render-react-email-demo Ready Ready Preview, v0 Oct 7, 2026 5:04pm UTC
json-render-react-pdf-demo Ready Ready Preview, v0 Oct 7, 2026 5:04pm UTC
json-render-react-three-fiber-demo Ready Ready Preview, v0 Oct 7, 2026 5:04pm UTC
json-render-remotion-demo Ready Ready Preview, v0 Oct 7, 2026 5:04pm UTC
json-render-solid-demo Ready Ready Preview, v0 Oct 7, 2026 5:04pm UTC
json-render-svelte-chat-demo Ready Ready Preview, v0 Oct 7, 2026 5:04pm UTC
json-render-svelte-demo Ready Ready Preview, v0 Oct 7, 2026 5:04pm UTC
json-render-vue Ready Ready Preview, v0 Oct 7, 2026 5:04pm UTC

@Railly
Railly merged commit 85a7fa0 into main Oct 12, 2026
25 checks passed
@ctate ctate mentioned this pull request Oct 13, 2026

This branch was successfully deployed

14 active deployments
Preview – json-render-svelte-chat-demo — 9ba52110 Deployed Oct 7, 2026 by vercel[bot]
Preview – json-render — 9ba52110 Deployed Oct 7, 2026 by vercel[bot]
Preview – json-render-chat-demo — 9ba52110 Deployed Oct 7, 2026 by vercel[bot]
Preview – json-render-react-three-fiber-demo — 9ba52110 Deployed Oct 7, 2026 by vercel[bot]
Preview – json-render-no-ai — 9ba52110 Deployed Oct 7, 2026 by vercel[bot]
Preview – json-render-game-engine-demo — 9ba52110 Deployed Oct 7, 2026 by vercel[bot]
Preview – json-render-dashboard-demo — 9ba52110 Deployed Oct 7, 2026 by vercel[bot]
Preview – json-render-react-email-demo — 9ba52110 Deployed Oct 7, 2026 by vercel[bot]
Preview – json-render-react-pdf-demo — 9ba52110 Deployed Oct 7, 2026 by vercel[bot]
Preview – json-render-remotion-demo — 9ba52110 Deployed Oct 7, 2026 by vercel[bot]
Preview – json-render-image-demo — 9ba52110 Deployed Oct 7, 2026 by vercel[bot]
Preview – json-render-vue — 9ba52110 Deployed Oct 7, 2026 by vercel[bot]
Preview – json-render-svelte-demo — 9ba52110 Deployed Oct 7, 2026 by vercel[bot]
Preview – json-render-solid-demo — 9ba52110 Deployed Oct 7, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants