Skip to content

fix(devtools): honor production bundles without a process global - #386

Closed
xiehuanyi wants to merge 1 commit into
vercel-labs:mainfrom
xiehuanyi:fix/browser-production-guard-377
Closed

xiehuanyi wants to merge 1 commit into
vercel-labs:mainfrom
xiehuanyi:fix/browser-production-guard-377

Conversation

@xiehuanyi

Copy link
Copy Markdown

Production bundles replace process.env.NODE_ENV, but the surrounding typeof process check previously returned false in browsers with no process global. Check the replaceable expression directly and catch unavailable globals for unbundled consumers so framework adapters honor the production guard.

Closes #377.

Validation: all 16 devtools tests pass, including a real production bundle evaluated in a browser-like context without process and an unbundled no-process control; pnpm type-check passes all 60 tasks.

Copilot AI balanced review requested due to automatic review settings October 6, 2026 07:54

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@vercel

vercel Bot commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

@xiehuanyi is attempting to deploy a commit to the Vercel Labs Team on Vercel.

A member of the Team first needs to authorize it.

@xiehuanyi xiehuanyi closed this Oct 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(devtools-svelte): production builds still mount the devtools panel

2 participants