Skip to content

fix(core): validate props against the selected catalog entry - #384

Closed
xiehuanyi wants to merge 1 commit into
vercel-labs:mainfrom
xiehuanyi:fix/catalog-component-props-378
Closed

xiehuanyi wants to merge 1 commit into
vercel-labs:mainfrom
xiehuanyi:fix/catalog-component-props-378

Conversation

@xiehuanyi

Copy link
Copy Markdown

With multiple catalog components, validate() previously accepted arbitrary concrete props instead of checking the component selected by type. Pair catalog references with their propsOf schemas so validation, parsed defaults/transforms, and JSON Schema export consistently use the selected entry.

Closes #378.

Validation: all 571 core tests pass, including regressions for invalid numeric props, props belonging to another component, and defaults/transforms; pnpm type-check passes all 60 tasks; the core declaration build also passes.

Copilot AI balanced review requested due to automatic review settings October 6, 2026 07:40

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@vercel

vercel Bot commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

@xiehuanyi is attempting to deploy a commit to the Vercel Labs Team on Vercel.

A member of the Team first needs to authorize it.

@xiehuanyi xiehuanyi closed this Oct 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(core): multi-component catalogs accept invalid concrete props

2 participants