Repository navigation
Conversation
The react peer range is now ^18.0.0 || ^19.0.0, and the lockfile specifier matches it while the resolved version stays 19.2.4. The installation page states that range alongside zod ^4.0.0, and the docs baseline hashes for that page are updated to the new content. A vitest reads the package manifest and expects peerDependencies.react to be ^18.0.0 || ^19.0.0, with react-dom left out of peerDependencies. Fixes vercel-labs#329
Contributor
|
@mvanhorn is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
The previous commit set the react peer range in packages/react/package.json to ^18.0.0 || ^19.0.0 but left the lockfile specifier at ^19.2.3, so pnpm install --frozen-lockfile failed in CI. Regenerated with pnpm 11.1.3; the resolved version stays 19.2.4.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
React 18 apps that depend on @json-render/react fail npm's peer dependency check. The package requires react ^19.2.3, so those installs only succeed when the peer warning is overridden. peerDependencies.react in @json-render/react was ^19.2.3, a range that does not match any React 18 release. The workspace lockfile stored that same specifier and still resolved react 19.2.4, and the installation docs listed the peer as react ^19.0.0.
Summary
The react peer range is now ^18.0.0 || ^19.0.0, and the lockfile specifier matches it while the resolved version stays 19.2.4. The installation page states that range alongside zod ^4.0.0, and the docs baseline hashes for that page are updated to the new content. A vitest reads the package manifest and expects peerDependencies.react to be ^18.0.0 || ^19.0.0, with react-dom left out of peerDependencies.
Verification
A frozen lockfile install of the workspace completes after the peer specifier change.
Closes #329