Repository navigation
XR Actions: Corrected use of r_hand role string to right_hand when creating custom properties. - #56
Merged
Conversation
…ation conditional. Signed-off-by: Ethan Porcaro <ethan@varrett.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
apply_poses, custom properties are created for triggers, buttons, thumbsticks, etc. These properties are only created for controllers, and are skipped for thr HMD and any Vive trackers. This was implemented in #52, commit 39cc0ad.The controller check should compare
role_stringto the stringsleft_handandright_hand. However, the stingr_handwas mistakenly used instead.This prevented custom properties from being created for extra inputs on the right hand, so they failed to record and preview. Controller transformation was unaffected, since it was not guarded by the controller-only check.
This PR corrects the string comparison for the right hand
role_string, making it consistent with that of the left hand.