Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In character mode each cell shows only two colors, so fine fronds, corn and raked gravel broke into speckle that shimmered as it moved, and quadrant terminals flickered. Scenes now know when they draw for terminal cells and draw bolder there.
Snaps and pixel mode are unchanged. Fronds and corn stay near-silhouettes under rim light on cells. Documented in CONTRIBUTING.
Evidence
Terminal previews, before (main) on the left, after on the right; the last row is quadrant mode.
Verification:
bun run typecheckpasses; CI's check job runsdev/check.ts(flicker, errors) on this branch; quadrant mode (WALLPAPER_OCTANTS=0) is checked on the integration branch in #1.Merge Danger
Door: two-way
Blast Radius: engine
Touches the cell-fitting path in
src/engine.tsxfor every wallpaper;Scene.resizegains an optional argument, so existing scenes keep working.Merged together with the other visual improvements in #1; this PR's CI screenshot check fails by design because screenshots are regenerated there.