Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Water was painted as flat color with highlights, so it didn't read as water. A new
reflect()insrc/water.tsmirrors the scene into water rows with drifting ripples, a tint and a per-pixel weight.+src/water.ts reflect(hdr, W, H, y0, y1, rows, amp, weight, tint, time, still?) beach sky, boat and birds mirrored in the sea each frame prehistoric volcano and sky mirrored in the lake each frame tundra still reflection in the ice, once in layout()Anything drawn in front of the water after it was painted stays in front of its reflection. Also slows the beach's crest highlights to keep flicker down and keeps its night glints saturated.
Evidence
Before (main) on the left, after on the right.
Lake and ice
Verification:
bun run typecheckpasses; CI's check job runsdev/check.ts(errors, frame time, flicker) on this branch.Merge Danger
Door: two-way
Blast Radius: visuals
Beach, prehistoric and tundra; a per-frame reflection pass over the water rows adds some frame cost.
Merged together with the other visual improvements in #1; this PR's CI screenshot check fails by design because screenshots are regenerated there.