Repository navigation
Give every night clear light structure - #4
Merged
Merged
Conversation
…light on the ground
…reflies that light the leaves
…pen barn door and fireflies that light the grass
…o light on the snow
…glow; share the campfire
…ims and lamps that light the sidewalk
…bank and a shared firefly glow
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Night scenes were dark and murky, so silhouettes and creatures got lost. Each night now has clear light structure: a lighter horizon band for silhouettes to stand against, strong moonlit rims, and a few warm pools of light that ground and creatures pick up as they pass.
The helpers are exported from the API and the night rules documented in CONTRIBUTING.
Evidence
Before (main) on the left, after on the right.
Verification:
bun run typecheckpasses; CI's check job runsdev/check.tson this branch.Merge Danger
Door: two-way
Blast Radius: visuals
Night looks of all ten wallpapers; the area behind text is kept no brighter than before.
Merged together with the other visual improvements in #1; this PR's CI screenshot check fails by design because screenshots are regenerated there.