Repository navigation
Conversation
…ow, flickering fires, lanterns, lava and neon
# Conflicts: # wallpapers/beach.ts # wallpapers/city.ts # wallpapers/desert.ts # wallpapers/farm.ts # wallpapers/prehistoric.ts # wallpapers/tundra.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moving light (the aurora, campfires, lava, neon) only lit itself; nothing around it changed.
src/lightmap.tsadds a low-resolution light map: scenes drop light nodes into a coarse grid each frame, andLightMap.apply()spreads it over the ground they light.firelight()gives fires a shared flicker andauroraFold()the aurora's travelling folds.Refinements:
LightMap.apply()touches the runs of blocks it lights, so cells reused by dirty-cells pick up the moving light (--verify-dirtypasses).Evidence
After the refinements, previews behind text, origin/main (left) vs this branch (right):
Cost,
dev/check.ts tundra desert prehistoric cityback to back twice: 6.37 → 6.63 ms/frame. Worst flicker unchanged (86 cells).Verified: typecheck, build,
dev/check.ts --max-ms=60in octant and quadrant mode (0 failed),--verify-dirty90/90 with every lit pixel inside the touched boxes; screenshots regenerated.Merge Danger
Door: two-way
Blast Radius: the look of night and sunset scenes with fires, lava, neon or aurora.