Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI took about 4 minutes per run:
dev/check.tsran all 90 combinations serially (223 s) and the screenshot check rendered all 30 images on one machine (145 s).Now a small job lists the registered wallpapers and
checkandscreenshotsrun as one job per wallpaper in parallel, picking up new wallpapers automatically. Typecheck and build run in their own job alongside.dev/screenshots.tsaccepts wallpaper names to limit the check.The checks themselves are unchanged. Validated with actionlint.