Repository navigation
Draw stars as round dots on cells and splat moving specks - #19
Merged
Merged
Conversation
# Conflicts: # CONTRIBUTING.md # dev/cells.ts # src/canvas.ts # src/engine.tsx # src/sky.ts # src/wallpaper.ts # src/weather.ts # wallpapers/beach.ts # wallpapers/city.ts # wallpapers/farm.ts # wallpapers/prehistoric.ts # wallpapers/template.ts # wallpapers/tundra.ts # wallpapers/zen.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stars and other small lights were drawn into the scene's pixels, so each one became a square sub-pixel block that jumped between cells as it twinkled. Still points now register with
Canvas.point()and the engine draws them as round dot glyphs on otherwise flat cells; moving specks (snow, sparks, fireflies) aresplat()ed across neighbouring pixels so they glide instead of hopping.Refinement: stars skip the sun and moon discs (
onOrb()against the orbspaintSkyand the desert sky record), so none shine through the moon.Evidence
Tundra night preview, origin/main (left) vs this branch (right): small round stars, none on the moon.
Flicker at night (
dev/check.ts, mean over night combinations) 32.6 → 31.6 cells per frame; tundra teeming night 53 → 47. Cost,dev/check.ts tundra space desert zenback to back twice: 5.34 → 5.43 ms/frame.Verified: typecheck, build,
dev/check.ts --max-ms=60in octant and quadrant mode (0 failed),--verify-dirty90/90; screenshots regenerated.Merge Danger
Door: two-way
Blast Radius: stars and particles in every wallpaper; dot glyphs (
·,∙,•) depend on the terminal font.