Repository navigation
Draw soft light as gradient-aligned bands in low-contrast cells - #17
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In low-contrast cells (glows, haze, sky gradients) the free two-color fit picked whatever octant pattern happened to fit best, so soft light came out as speckle.
bandSplit()now gives those cells a split aligned with the gradient: halves, quarters or a middle stripe, kept with the same hysteresis as other splits.Evidence
Reference (scene, brightened) | before (origin/main) | after:
Cost,
dev/check.ts tundra ocean city jungleback to back twice: 7.20 → 7.40 ms/frame. Worst flicker 83 → 87 cells (limit 150).Verified: typecheck, build,
dev/check.ts --max-ms=60in octant and quadrant mode (0 failed),--verify-dirty90/90, screenshots up to date.Merge Danger
Door: two-way
Blast Radius: glyphs in soft cells of every wallpaper.