Repository navigation
Refit only the cells that can change - #15
Merged
Merged
Conversation
# Conflicts: # CONTRIBUTING.md # src/canvas.ts # src/engine.tsx # src/sky.ts # wallpapers/beach.ts # wallpapers/city.ts # wallpapers/desert.ts # wallpapers/farm.ts # wallpapers/jungle.ts # wallpapers/ocean.ts # wallpapers/prehistoric.ts # wallpapers/template.ts # wallpapers/tundra.ts # wallpapers/zen.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Most cells show the same thing frame after frame, yet every cell was refit every frame. Now the canvas records what each frame draws over the cached background, and the engine refits only the cells that can have changed and reuses last frame's fit for the rest.
This branch's own incremental
finish()overlapped with static-bloom's; the merge keeps static-bloom's block bloom (its accuracy, and simpler) and feedschangedfrom it.bun dev/check.ts --verify-dirtyplays every combination twice (full refit vs dirty refit, with text edits, redraws and agent events mixed in) and fails on any cell that differs.Evidence
Engine + scene per frame,
dev/check.ts tundra ocean city jungle(36 combinations), origin/main vs this branch, back to back twice: 8.9 → 6.1 ms/frame.Left: the scene; right: cells refitted per frame (magenta).
Verified: typecheck, build,
dev/check.ts --max-ms=60in octant and quadrant mode (0 failed),--verify-dirty90/90 bit-identical, screenshots up to date.Merge Danger
Door: two-way
Blast Radius: every wallpaper; a scene that draws outside its touched boxes leaves stale cells until they change (
--verify-dirtycatches it).WALLPAPER_DIRTY=0refits everything.