Repository navigation
Bloom and tone-map the static background once - #13
Merged
Merged
Conversation
# Conflicts: # src/canvas.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bloom and tone mapping ran over the whole scene every frame, though most of it never changes. Now
layout()blooms and tone-maps the static background once; each frame only the 4×4 bloom blocks whose light differs from the background are blurred and tone-mapped again. The blur and tone map loops are faster too.Evidence
Scene cost per frame (step + render at 320×180, every wallpaper and time, teeming), origin/main vs this branch back to back:
finish()Output stays within 1 level of 255 of the full-frame bloom:
Verified: typecheck, build,
dev/check.ts --max-ms=60in octant and quadrant mode (0 failed), screenshots up to date.Merge Danger
Door: two-way
Blast Radius:
Canvas.finish()for every wallpaper; a scene that changes pixels without going through the background diff would show stale bloom.