Repository navigation
Move subjects out from behind text and steer creatures with a text map - #11
Merged
Merged
Conversation
…ssion preview layouts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Barns, volcanoes and resting creatures sat in the middle of the screen, right behind OpenCode's logo and prompt. Focal points now sit toward the edges, top and bottom, and the engine tells scenes where text actually is so creatures avoid it.
sequenceDiagram participant Engine participant Scene Engine->>Scene: textMap({cols, rows, cover}) on start, then ~1/s Scene->>Scene: openSpot(x0, x1, y0, y1) least-covered stop for a creature or visitor Scene->>Scene: openRow(y0, y1) height for something crossing the screenPositions are measured in screen heights from the nearest edge so they hold on wide and narrow terminals. The octopus, ice fisher and penguins keep clear of the prompt.
dev/preview.tsgainshomeandsessionlayouts and a size argument; documented in CONTRIBUTING.Evidence
Before (main) on the left, after on the right.
Terminal sizes

Verification:
bun run typecheckpasses; CI's check job runsdev/check.tson this branch.Merge Danger
Door: two-way
Blast Radius: layout
Every wallpaper's composition moves;
Scene.textMapis optional, so existing scenes keep working.Merged together with the other visual improvements in #1; this PR's CI screenshot check fails by design because screenshots are regenerated there.