refactor(core): rename payment deadline fields to half/full - #560
Merged
Conversation
The names first_payment_deadline and most_payment_deadline no longer described what the fields do. Both already carried help_text reading "Deadline for half payment." and "Deadline for full payment.", and the logic in Student.payment_status agrees: the first deadline is only consulted while more than half the cost is still owed, and the "most" deadline governs the invoice until it is paid off entirely. "most" was the more misleading of the two, since it reads as "most of the payment" but actually gates the full balance. "first" was also inaccurate in the one_semester_date branch, where an invoice created after that date skips the half deadline and the first deadline the student sees is the full one. Rename them to half_payment_deadline and full_payment_deadline, and update the payment_status docstring to match. The migration uses RenameField for both columns, so the existing deadline values are preserved rather than dropped and recreated. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YKdgZFEJqFsCRkaUcFLMm6
vEnhance
pushed a commit
that referenced
this pull request
Aug 25, 2026
#560 landed its own core migration numbered 0072, so both branches had a 0072 depending on 0071 and the graph had two leaf nodes. Renumbered ours to 0073 and pointed it at theirs, rather than adding a merge migration. The two RenameFields touch different models (Semester vs UserProfile), so linearizing them is order-independent. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012tmVNTck2f5p5pJez64MmT
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
more descriptive names