Skip to content

fix: apply Android bitrate and frame rate settings - #29

Merged
hatemragab merged 1 commit into
mainfrom
fix/issue-26-android-encoding-controls
Sep 19, 2026
Merged

hatemragab merged 1 commit into
mainfrom
fix/issue-26-android-encoding-controls

Conversation

@hatemragab

Copy link
Copy Markdown
Member

Summary

  • apply explicit Android videoBitrate through Media3 VideoEncoderSettings
  • lower Android output frame rate with FrameDropEffect without attempting to upsample
  • preserve the existing H.264 profile/level request in the same encoder factory
  • centralize and unit-test bitrate/frame-rate resolution

Compatibility

  • no channel-schema or minimum-platform changes
  • bitrate requests remain advisory because device encoders may apply fallback
  • no Android hardware/device run was performed; validation is compile, lint, and unit-test based

Validation

  • flutter analyze --no-pub
  • flutter test --no-pub (97 tests)
  • ./gradlew :v_video_compressor:testDebugUnitTest :v_video_compressor:lintDebug :app:assembleDebug --console=plain (21 native tests, lint, debug APK assembly)
  • git diff --check

Fixes #26

@hatemragab
hatemragab merged commit 36d890f into main Sep 19, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Android: frameRate and videoBitrate in VVideoAdvancedConfig never reach the encoder

1 participant